Smarter bundling strategy #60
Conversation
…nto peer-dependency-bundling
| "@storybook/blocks": "7.0.0", | ||
| "@storybook/components": "7.0.0", | ||
| "@storybook/core-events": "7.0.0", | ||
| "@storybook/manager": "0.0.0-pr-24676-sha-214a6f84", |
There was a problem hiding this comment.
temporarily reference canary release until storybookjs/storybook#24676 has been released.
This doesn't have an affect on any addon's bundling as they should only reference these packages in the tsup config, not in their sources.
There was a problem hiding this comment.
Now that Storybook 7.6 has been released, these should be 7.6.0 instead of the canary versions. This was adressed in #62
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @storybook/blocks@7.5.3, @storybook/components@7.5.3, @storybook/core-events@7.5.3, @storybook/manager-api@7.5.3, @storybook/preview-api@7.5.3, @storybook/theming@7.5.3, @storybook/types@7.5.3 |
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
| "bundler": { | ||
| "exportEntries": ["src/index.ts"], | ||
| "managerEntries": ["src/manager.ts"], | ||
| "previewEntries": ["src/preview.ts"] | ||
| }, |
There was a problem hiding this comment.
this is referenced by the tsup config, and can be modified by addon authors if they want, as long as the export map above is kept in sync.
We could also not do this and just keep these lists directly in the tsup config like we currently do. I don't have a strong oppinion.
|
@SocketSecurity ignore @storybook/manager@* @storybook/preview@* |
Telescopes on top of #59
Works on storybookjs/storybook#24490
This PR splits bundling of the entry points into three different types of entries: manager entries, preview entries and export entries. The reason for this should be written in the README. If anything is unclear about that we should update the README accordingly.